Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Google+ support #2155

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Remove Google+ support #2155

merged 4 commits into from
Nov 21, 2023

Conversation

0xA50C1A1
Copy link
Contributor

@0xA50C1A1 0xA50C1A1 commented Nov 17, 2023 •
edited
Loading

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Google+ was discontinued in 2019, so I think that its protocol id can be freed for reuse.

0xA50C1A1 and others added 4 commits November 18, 2023 00:12
Remove Google+ support
157bb01 
Google+ was discontiued in 2019, so I think that its protocol id can be freed for reuse.
@0xA50C1A1
Fix typo
9839234
@0xA50C1A1
Merge branch 'ntop:dev' into remove/google_plus
494059f
Update tests
c07717b
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@IvanNardi
Copy link
Collaborator

Could you fill in the CLA, please?

@0xA50C1A1
Copy link
Contributor Author

Could you fill in the CLA, please?

Done.

IvanNardi
IvanNardi approved these changes Nov 18, 2023
View reviewed changes
Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense

@IvanNardi IvanNardi merged commit 8d71998 into ntop:dev Nov 21, 2023
33 checks passed
@IvanNardi
Copy link
Collaborator

Thanks

@0xA50C1A1 0xA50C1A1 deleted the remove/google_plus branch November 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvanNardi IvanNardi IvanNardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xA50C1A1 @IvanNardi